Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve unit test to work on every OS with multiple configurations #422

Merged
merged 26 commits into from
Feb 14, 2023
Merged

Improve unit test to work on every OS with multiple configurations #422

merged 26 commits into from
Feb 14, 2023

Conversation

nicolas-rabault
Copy link
Member

@nicolas-rabault nicolas-rabault commented Feb 8, 2023 •
edited by JeromeGalan
Loading

By submiting this PR, you agree with the associated license (Apache 2.0 or MIT) and with our Contributor License Agreement (CLA).

Changes

Please choose the relevant options:

  • New feature (non-breaking change which adds functionality)

Related issue(s)

Provide a list of the related issues that will be fixed by this PR.

WARNING: Do not edit the checklist below.

Developer section

  • [Documentation] is up to date with new feature
  • [Tests] are passed OK (non regression, new features & bug fixes)
  • [Code Quality] please check if:
    • Each function has a header (description, inputs, outputs)
    • Code is commented (particularly in hard to understand areas)
    • There are no new warnings that can be corrected
    • Commits policy is respected (constitancy commits, clear commits comments)

QA section

  • [Review] tests for new features have been reviewed
  • [Changelog] is up-to-date with expected tags
    🆕 Feature: [Feature] Description...
    🆕 Added: [Feature] Description...
    🆕 Changed: [Feature] Description...
    🛠️ Fix: [Feature] Description...

@nicolas-rabault nicolas-rabault added this to the 2.9.0 milestone Feb 8, 2023
@nicolas-rabault nicolas-rabault self-assigned this Feb 8, 2023
@nicolas-rabault nicolas-rabault force-pushed the feat/improve_unit_test branch 2 times, most recently from b76cf5a to 9cecc8c Compare February 10, 2023 11:04
@nicolas-rabault nicolas-rabault force-pushed the feat/improve_unit_test branch 2 times, most recently from 8a7894f to 8a9bc1e Compare February 14, 2023 09:03
JeromeGalan
JeromeGalan approved these changes Feb 14, 2023
View reviewed changes
Copy link
Member

@JeromeGalan JeromeGalan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good improvment!

Merge pull request #424 from Luos-io/feat/secure_tests_default_scenario
6bdaddc 
Secure unit test default scenario and cleanup build and stuff
@JeromeGalan JeromeGalan merged commit f3ca2a8 into rc_2.9.0 Feb 14, 2023
@JeromeGalan JeromeGalan deleted the feat/improve_unit_test branch February 14, 2023 23:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JeromeGalan JeromeGalan JeromeGalan approved these changes

Assignees

@nicolas-rabault nicolas-rabault

Labels
None yet
Projects
None yet
Milestone
2.9.0
Development

Successfully merging this pull request may close these issues.
2 participants
@nicolas-rabault @JeromeGalan