Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Robus protocol timeout #410

Merged
merged 1 commit into from
Dec 14, 2022
Merged

Robus protocol timeout #410

merged 1 commit into from
Dec 14, 2022

Conversation

Salem-Tho
Copy link
Member

@Salem-Tho Salem-Tho commented Dec 13, 2022

PR Description section

Some architecture like STM32F4 does not have a "start byte detection". this byte detection allow to overlap the timeout of robus if a byte receiving is pending. To prevent problem of MCU differentes frequency and "start byte detection" this fix will soften the robus protocol

Description and dependencies

Please include here a summary of the changes and the related issue. List any dependencies that are required for this change.

Changes

Please choose the relevant options:

  • Bug fix (non-breaking change which fixes an issue)

Related issue(s)

Provide a list of the related issues that will be fixed by this PR.


WARNING: Do not edit the checklist below.


Developer section

  • [Documentation] is up to date with new feature
  • [] [Tests] are passed OK (non regression, new features & bug fixes)
  • [Code Quality] please check if:
    • Each function has a header (description, inputs, outputs)
    • Code is commented (particularly in hard to understand areas)
    • There are no new warnings that can be corrected
    • Commits policy is respected (constitancy commits, clear commits comments)

QA section

  • [Review] tests for new features have been reviewed
  • [Changelog] is up-to-date with expected tags
    🆕 Feature: [Feature] Description...
    🆕 Added: [Feature] Description...
    🆕 Changed: [Feature] Description...
    🛠️ Fix: [Feature] Description...

@Salem-Tho Salem-Tho added the type bug Something isn't working label Dec 13, 2022
@Salem-Tho Salem-Tho added this to the 2.8.0 milestone Dec 13, 2022
@Salem-Tho Salem-Tho self-assigned this Dec 13, 2022
@Salem-Tho Salem-Tho force-pushed the fix/protocol_timeout branch from 12ad02b to f1b1b90 Compare December 14, 2022 13:30
Copy link
Member

@nicolas-rabault nicolas-rabault left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This value shouldn' be in HAL but in Robus configurations.
Also this value should be in byte duration and not in us. If we change the baudrate this val should move proportionally...
Let keep it for later.

@JeromeGalan JeromeGalan merged commit aedbd7b into rc_2.8.0 Dec 14, 2022
@JeromeGalan JeromeGalan deleted the fix/protocol_timeout branch December 14, 2022 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants