diff --git a/PENDING.md b/PENDING.md index 7130482209..1b473460f0 100644 --- a/PENDING.md +++ b/PENDING.md @@ -3,8 +3,12 @@ ### Added - [\#2104](https://github.com/cosmos/voyager/issues/2104) fix transaction times @fedekunze +- [\#1805](https://github.com/cosmos/voyager/issues/1805) support all transaction types @fedekunze ### Changed - [#\2202](https://github.com/cosmos/voyager/pull/2202) Fix circle configuration for publishing @sabau -- [\#1805](https://github.com/cosmos/voyager/issues/1805) support all transaction types @fedekunze + +### Fixed + +- [#\2202](https://github.com/cosmos/voyager/issues/2202) Fix number conversions @faboweb diff --git a/PULL_REQUEST_TEMPLATE.md b/PULL_REQUEST_TEMPLATE.md index 0e9cf7f2d4..58c093bf6c 100644 --- a/PULL_REQUEST_TEMPLATE.md +++ b/PULL_REQUEST_TEMPLATE.md @@ -10,7 +10,7 @@ Thank you! 🚀 For contributor: -- [ ] Added entries in `CHANGELOG.md` with issue # and GitHub username +- [ ] Added entries in `PENDING.md` with issue # and GitHub username - [ ] Reviewed `Files changed` in the github PR explorer - [ ] Attach screenshots of the UI components on the PR description (if applicable) - [ ] Scope of work approved for big PRs diff --git a/app/src/renderer/components/governance/PageProposal.vue b/app/src/renderer/components/governance/PageProposal.vue index 19cac1594d..c9fcbc3ce6 100644 --- a/app/src/renderer/components/governance/PageProposal.vue +++ b/app/src/renderer/components/governance/PageProposal.vue @@ -200,16 +200,18 @@ export default { .toNumber() }, yesPercentage({ tally, totalVotes } = this) { - return num.percentInt(tally.yes / totalVotes) + return num.percentInt(totalVotes === 0 ? 0 : tally.yes / totalVotes) }, noPercentage({ tally, totalVotes } = this) { - return num.percentInt(tally.no / totalVotes) + return num.percentInt(totalVotes === 0 ? 0 : tally.no / totalVotes) }, noWithVetoPercentage({ tally, totalVotes } = this) { - return num.percentInt(tally.no_with_veto / totalVotes) + return num.percentInt( + totalVotes === 0 ? 0 : tally.no_with_veto / totalVotes + ) }, abstainPercentage({ tally, totalVotes } = this) { - return num.percentInt(tally.abstain / totalVotes) + return num.percentInt(totalVotes === 0 ? 0 : tally.abstain / totalVotes) }, tally({ proposals, proposalId } = this) { const { yes, no, abstain, no_with_veto } = diff --git a/app/src/renderer/components/staking/LiValidator.vue b/app/src/renderer/components/staking/LiValidator.vue index 8a16606ce4..8419cb7234 100644 --- a/app/src/renderer/components/staking/LiValidator.vue +++ b/app/src/renderer/components/staking/LiValidator.vue @@ -100,8 +100,9 @@ export default { const info = this.validator.signing_info if (info) { // uptime in the past 10k blocks - const uptimeRollingWindow = info.signed_blocks_counter / rollingWindow - return `${this.num.pretty(uptimeRollingWindow * 100)}%` + const uptimeRollingWindow = + (rollingWindow - info.missed_blocks_counter) / rollingWindow + return num.percent(uptimeRollingWindow) } return `--` }, @@ -163,15 +164,15 @@ export default { const validatorRewards = this.distribution.rewards[ this.validator.operator_address ] - return validatorRewards ? num.shortNumber( - num.atoms(validatorRewards[this.bondDenom]) || 0 - ) : null + return validatorRewards + ? num.shortNumber(num.atoms(validatorRewards[this.bondDenom]) || 0) + : null } }, watch: { lastHeader: { immediate: true, - handler(){ + handler() { if (this.yourVotes > 0) { this.$store.dispatch( `getRewardsFromValidator`, diff --git a/app/src/renderer/components/transactions/LiBankTransaction.vue b/app/src/renderer/components/transactions/LiBankTransaction.vue index c6ce774447..bd9567315e 100644 --- a/app/src/renderer/components/transactions/LiBankTransaction.vue +++ b/app/src/renderer/components/transactions/LiBankTransaction.vue @@ -6,24 +6,18 @@ >