Change time format to 24h #1800
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- change times to agree with fixed-time - fix transactions enrichment to match props expectations Signed-off-by: Karoly Albert Szabo <[email protected]>
Codecov Report
@@ Coverage Diff @@
## develop #1800 +/- ##
===========================================
+ Coverage 95.05% 95.05% +<.01%
===========================================
Files 123 123
Lines 2951 2953 +2
Branches 120 121 +1
===========================================
+ Hits 2805 2807 +2
Misses 137 137
Partials 9 9
|
sabau
commented
Jan 7, 2019
| @@ -50,13 +50,13 @@ describe(`Module: Transactions`, () => { | |||
| blockHeight: `3436`, | |||
| blockMetaInfo: { | |||
| header: { | |||
| time: 1042 | |||
| time: 42000 | |||
There was a problem hiding this comment.
This is caused by the global Date override in jest
- for transactions older than today, show all date Signed-off-by: Karoly Albert Szabo <[email protected]>
faboweb
approved these changes
Jan 7, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1720
Description:
❤️ Thank you!
CHANGELOG.mdwith issue # and GitHub usernameFiles changedin the github PR explorer