Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AR doesn't properly split keywords that the CR combines into one section #45

Closed
KingSupernova31 opened this issue Jun 8, 2023 · 2 comments · Fixed by #47
Closed

AR doesn't properly split keywords that the CR combines into one section #45

KingSupernova31 opened this issue Jun 8, 2023 · 2 comments · Fixed by #47

Comments

@KingSupernova31
Copy link

KingSupernova31 commented Jun 8, 2023

https://api.academyruins.com/cr/keywords

Currently affects daybound/nightbound and tap/untap. AR thinks that the string "daybound and nightbound" is a single keyword.

Probably the best fix would be to split any keyword that contains the string " and ", though that runs the risk of breaking if Wizards ever releases a multi-word keyword that includes "and". Keywords are supposed to be short and elegant though, so I doubt they'll do that any time soon.

@lunakv lunakv mentioned this issue Jun 12, 2023
@KingSupernova31
Copy link
Author

Is there an easy way to tell when changes like these have gone live, or were supposed to go live? I notice it's still not working on the live API, and I want to report that if it's a bug, but if the delay is intended and it's going to go live in the future I don't want to be a bother about it.

@lunakv
Copy link
Owner

lunakv commented Jul 4, 2023

All changes go live whenever a release is published. With this change in particular, the code that generates the keyword list is updated in production, but I didn't think to swap out the current keywords file with a new one. I'll try to do that, at the very latest this change will be in effect after a new CR release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants