Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exception and ESP32 restart due to missing check for connection in method "eQ3::onTick()" #3

Open
KlausMu opened this issue Aug 2, 2021 · 1 comment

Comments

@KlausMu
Copy link

KlausMu commented Aug 2, 2021

In file "lib/eQ3/eQ3.cpp" in method "bool eQ3::onTick()" I had to replace the block

        } else {
            sendNextFragment();
            lastActivity = time(NULL);
        }

with

        } else if (state.connectionState != DISCONNECTED) {
            sendNextFragment();
            lastActivity = time(NULL);
        }

otherwise I got exceptions and restarts of the ESP32.

Looking at the code it seems that the original author was aware that this code needed some more fine tuning.

@KlausMu
Copy link
Author

KlausMu commented Oct 17, 2024

In the meantime, this change is included in this pull request

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant