-
-
Notifications
You must be signed in to change notification settings - Fork 102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support deno.jsonc
for Deno config file
#211
Comments
As you said, Lume needs to read and write Personally, I think it was a bad idea from Deno developers to allow to use jsonc here, it's not standard, introduce a unneeded complexity and inconsistency (what happens if When Deno standard library include a option to parse and stringify JSONC, I'll consider support it, althought I think everybody should use json format. |
Because Deno follows the spec, which only uses JSON: denoland/deno#12993 |
Upgrading Lume still yields this error:
Btw, there is a std lib for jsonc now: @std/jsonc - JSR |
@ooker777 You're right. In recent Lume versions the upgrade script has changed and jsonc files are not loaded. I'll fix it. |
Summary
Currently, Lume only supports
deno.json
files. Deno itself supportsdeno.jsonc
files as well. Ideally, Lume would match Deno's behavior.Brainstorming
std/encoding
. It does not include a method for serializing JSONC (see https://github.com/denoland/deno_std/discussions/1803).std/encoding
, and doing some RegExp magic to overwrite a portion of the file. Just brainstorming here.Notes
The text was updated successfully, but these errors were encountered: