-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cannot find name '__instanceof'. in the "assemblyscript": "^0.27.5", #6
Comments
AssemblyScript/assemblyscript#2555 is the relevant PR, and it removes import {releaseObject} from './imports'
import {JSObject} from './JSObject'
// @ts-ignore
@global
function __finalize(ptr: usize): void {
if (changetype<Object>(ptr) instanceof JSObject) {
releaseObject(ptr)
}
} This snippet takes advantage of AssemblyScript/assemblyscript#2559, where Implementing this change would break users of |
Thanks for the analysis @CountBleck! I think it is fine to move forward with support only for the latest AssemblyScript, and providing a note about migration if needed. We don't have the time/resources to maintain workarounds for multiple versions, so getting it up to date with only the latest AS would be ok. |
Any chance this is going to get merged ? |
Cannot find name '__instanceof'. in the "assemblyscript": "^0.27.5",
"ecmassembly": "^0.1.8", works fine
The text was updated successfully, but these errors were encountered: