Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Viz): viz provider and line chart added #3376

Merged
merged 32 commits into from
Jun 15, 2023

Conversation

MEsteves22
Copy link
Contributor

@MEsteves22 MEsteves22 commented May 25, 2023

  • HvVizProvider created for visualisations themes.
  • HvLineChart created: line, stacked, area, range slider, and multiple series.

At the moment the data can either be columns, rows, or an arquero table. In the future, we can add new data formats such as CSV, JSON, Apache Arrow, and so on.

This is a first iteration for charts. We will most likely need to refactor the code along the way if other charts need to share the same API. For now I decided to keep the code as it is since I believe this is something that will make more sense in the future when working on the other charts.

@MEsteves22 MEsteves22 marked this pull request as draft May 25, 2023 18:47
@github-actions github-actions bot temporarily deployed to uikit/pr-3376 May 25, 2023 19:09 Destroyed
@MEsteves22 MEsteves22 force-pushed the feat/viz-provider-line-chart branch from e097f73 to 8a17bc5 Compare May 26, 2023 11:05
@github-actions github-actions bot temporarily deployed to uikit/pr-3376 May 26, 2023 11:21 Destroyed
@MEsteves22 MEsteves22 force-pushed the feat/viz-provider-line-chart branch from 8a17bc5 to df10d37 Compare May 26, 2023 11:30
@github-actions github-actions bot temporarily deployed to uikit/pr-3376 May 26, 2023 11:46 Destroyed
@MEsteves22 MEsteves22 force-pushed the feat/viz-provider-line-chart branch from df10d37 to 591f535 Compare May 30, 2023 15:55
@github-actions github-actions bot temporarily deployed to uikit/pr-3376 May 30, 2023 16:12 Destroyed
@MEsteves22 MEsteves22 force-pushed the feat/viz-provider-line-chart branch from 7f42236 to d478a0e Compare June 1, 2023 11:57
@github-actions github-actions bot temporarily deployed to uikit/pr-3376 June 1, 2023 12:14 Destroyed
@MEsteves22 MEsteves22 force-pushed the feat/viz-provider-line-chart branch from e13a79b to 36b22a4 Compare June 1, 2023 16:50
@github-actions github-actions bot temporarily deployed to uikit/pr-3376 June 1, 2023 17:15 Destroyed
@MEsteves22 MEsteves22 force-pushed the feat/viz-provider-line-chart branch 2 times, most recently from 1cc2c96 to d78dc4f Compare June 2, 2023 14:31
@github-actions github-actions bot temporarily deployed to uikit/pr-3376 June 2, 2023 14:49 Destroyed
@github-actions github-actions bot temporarily deployed to uikit/pr-3376 June 2, 2023 15:34 Destroyed
@github-actions github-actions bot temporarily deployed to uikit/pr-3376 June 2, 2023 16:20 Destroyed
@MEsteves22
Copy link
Contributor Author

I just noticed that when I started using setOptions the tooltip styling is no longer updating when the color mode is changed 😅 I will look into this.

@github-actions github-actions bot temporarily deployed to uikit/pr-3376 June 5, 2023 09:05 Destroyed
@MEsteves22
Copy link
Contributor Author

MEsteves22 commented Jun 5, 2023

The tooltip problem was fixed in my last commit. I had to stop updating the tooltip options with setOptions since it was not working this way. However, I need to update the remaining options with setOptions to use replaceMerge and avoid the range slider to constantly reset its values when using dynamic data.

@MEsteves22 MEsteves22 force-pushed the feat/viz-provider-line-chart branch from f115107 to c907679 Compare June 6, 2023 16:32
@github-actions github-actions bot temporarily deployed to uikit-app/pr-3376 June 6, 2023 16:49 Destroyed
@github-actions github-actions bot temporarily deployed to uikit/pr-3376 June 6, 2023 16:49 Destroyed
@MEsteves22 MEsteves22 force-pushed the feat/viz-provider-line-chart branch from c907679 to 45784d3 Compare June 6, 2023 17:11
@github-actions github-actions bot temporarily deployed to uikit-app/pr-3376 June 6, 2023 17:31 Destroyed
@github-actions github-actions bot temporarily deployed to uikit/pr-3376 June 6, 2023 17:31 Destroyed
@MEsteves22 MEsteves22 force-pushed the feat/viz-provider-line-chart branch from 45784d3 to 7255314 Compare June 7, 2023 09:12
@github-actions github-actions bot temporarily deployed to uikit-app/pr-3376 June 7, 2023 09:35 Destroyed
@MEsteves22 MEsteves22 force-pushed the feat/viz-provider-line-chart branch from c08d2ae to 95a1d8b Compare June 15, 2023 13:19
@github-actions github-actions bot temporarily deployed to uikit/pr-3376 June 15, 2023 13:38 Destroyed
@github-actions github-actions bot temporarily deployed to uikit-app/pr-3376 June 15, 2023 13:38 Destroyed
Copy link
Member

@zettca zettca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work 👍

Some minor notes (that can be handled later)

packages/viz/src/providers/Provider.tsx Show resolved Hide resolved
packages/viz/src/providers/Provider.tsx Outdated Show resolved Hide resolved
packages/viz/src/providers/Provider.tsx Outdated Show resolved Hide resolved
@github-actions github-actions bot temporarily deployed to uikit-app/pr-3376 June 15, 2023 14:12 Destroyed
@github-actions github-actions bot temporarily deployed to uikit/pr-3376 June 15, 2023 14:12 Destroyed
@github-actions github-actions bot temporarily deployed to uikit-app/pr-3376 June 15, 2023 14:29 Destroyed
@github-actions github-actions bot temporarily deployed to uikit/pr-3376 June 15, 2023 14:29 Destroyed
@github-actions github-actions bot temporarily deployed to uikit-app/pr-3376 June 15, 2023 15:29 Destroyed
@github-actions github-actions bot temporarily deployed to uikit/pr-3376 June 15, 2023 15:29 Destroyed
@plagoa plagoa merged commit 18f67cc into master Jun 15, 2023
@plagoa plagoa deleted the feat/viz-provider-line-chart branch June 15, 2023 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants