-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(Viz): viz provider and line chart added #3376
Conversation
e097f73
to
8a17bc5
Compare
8a17bc5
to
df10d37
Compare
df10d37
to
591f535
Compare
7f42236
to
d478a0e
Compare
e13a79b
to
36b22a4
Compare
1cc2c96
to
d78dc4f
Compare
I just noticed that when I started using |
The tooltip problem was fixed in my last commit. I had to stop updating the tooltip options with |
f115107
to
c907679
Compare
c907679
to
45784d3
Compare
45784d3
to
7255314
Compare
Storybook fixed to not cut the tooltip. appendToBody doesn't work for scoped css.
c08d2ae
to
95a1d8b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome work 👍
Some minor notes (that can be handled later)
HvVizProvider
created for visualisations themes.HvLineChart
created: line, stacked, area, range slider, and multiple series.At the moment the data can either be columns, rows, or an arquero table. In the future, we can add new data formats such as CSV, JSON, Apache Arrow, and so on.
This is a first iteration for charts. We will most likely need to refactor the code along the way if other charts need to share the same API. For now I decided to keep the code as it is since I believe this is something that will make more sense in the future when working on the other charts.