Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

It's now harder to hack on the pugin: existing ide-sessions no longer restart automatically #30

Open
rvion opened this issue Oct 28, 2015 · 5 comments
Labels

Comments

@rvion
Copy link
Collaborator

rvion commented Oct 28, 2015

Before recent updates, when I was changing the plugin source code, stack-ide sessions in other sublimetext instances were restarting on their own, picking my latest modifications. It was very convenient to hack on the editor, and change things.

Now, It's no longer the case, so it' much harder to tweak the plugin or test fixes.
(the fix may be easy, but I'm not really familiar with python / subl hacking)

@rvion
Copy link
Collaborator Author

rvion commented Oct 28, 2015

ping @tomv564 @lukexi

@rvion
Copy link
Collaborator Author

rvion commented Oct 28, 2015

possibly related to #29

@tomv564
Copy link
Collaborator

tomv564 commented Oct 28, 2015

The restart command had no tests written against it either - I'll have a look at fixing it tonight!

@rvion rvion added bug ? and removed help wanted labels Oct 28, 2015
@rvion
Copy link
Collaborator Author

rvion commented Oct 28, 2015

Thanks for all the good work ! 👍

I hope my bug reports do not seem negative.
I really appreciate all the energy you're putting in this plugin !

@tomv564
Copy link
Collaborator

tomv564 commented Oct 29, 2015

When we had all the code in 1 module, the whole plugin was conveniently restarted by Sublime's module reload. Now the plugin is broken up over several modules, I think the following is happening:

  1. Module A imports Module B.
  2. You save changes to Module B
  3. Sublime Text reloads Module B
  4. Module A keeps running with old version of Module B in memory.
  5. New Module B loads a fresh version of module A which is never initialised through plugin_loaded().

In other words, your plugin keeps running but the new stuff doesn't talk to the old stuff.
The now-working SublimeStackIDE: Restart command may not help at all with this.

This thread discusses the problem: https://www.sublimetext.com/forum/viewtopic.php?f=6&t=6777
The solution mentioned by wbond can be seen here: https://github.com/jdivock/sublimesettings/blob/master/SVN/SVN.py

The tests are a way to get some quick iteration on a feature, but I agree that having the plugin reload itself (in the right order) is great for hacking away.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants