Skip to content
This repository has been archived by the owner on Feb 7, 2020. It is now read-only.

Bug. Scrollbar does NOT update when images are present #70

Open
neuropass opened this issue Oct 6, 2018 · 1 comment
Open

Bug. Scrollbar does NOT update when images are present #70

neuropass opened this issue Oct 6, 2018 · 1 comment

Comments

@neuropass
Copy link

neuropass commented Oct 6, 2018

I just noticed an issue.
If you post an image the scrollbar position is not updating. Does not synch to the bottom.
This issue is not present with regular text messages.

What does it do that with images only? What would be the possible fix for this behavior? @lukejacksonn

Thanks!

@lukejacksonn
Copy link
Owner

Hey! Yes this is a known issue.. so the problem is how to know when to scroll (that is, not when the images has been appended to the DOM but when the image been rendered in the list, loaded and taken shape). I played around for a long time trying to find a solution that works for all cases and ina ll browsers but really struggled!

Perhaps adding a call to this action https://github.com/pusher/react-slack-clone/blob/master/src/index.js#L150 inside an onload function on these elements https://github.com/pusher/react-slack-clone/blob/master/src/components/Message/index.js#L25 might work out.. I'm sure I tried it but not can't remember now.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants