-
-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(sirv): avoid false-positive on too big range end #147
Conversation
@dmkret is there a test that could be added for this to prevent a regression? |
@benmccann I've added a test and changed incorrect existing |
@dmkret I don't have merge rights on this repo |
Sorry I’m in the middle of a move. Will look tomorrow or Monday |
Codecov ReportPatch and project coverage have no change.
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more Additional details and impacted files@@ Coverage Diff @@
## master #147 +/- ##
=======================================
Coverage 62.23% 62.23%
=======================================
Files 2 2
Lines 143 143
=======================================
Hits 89 89
Misses 54 54 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
Closes #140