Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

data generator issue, may affect results. #8

Open
Luciennnnnnn opened this issue Aug 12, 2020 · 1 comment
Open

data generator issue, may affect results. #8

Luciennnnnnn opened this issue Aug 12, 2020 · 1 comment

Comments

@Luciennnnnnn
Copy link

Deep-SAD-PyTorch/src/datasets/preprocessing.py
In this file, row 45 46, idx_unlabeled_outlier and idx_known_outlier may intersect, since idx_known_outlier_candidates is a subset of idx_outlier.
That will affect the test results.

@codingidea
Copy link

Hi, there! @sfasdas

Have you evaluated how much this issue affects the results? It seems that the unlabeled outliers and the known outliers will have notable overlap only when their ratios ( r_p and r_l) are large enough.

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants