Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert to typescript #314

Closed
lukasoppermann opened this issue Feb 23, 2018 · 5 comments
Closed

Convert to typescript #314

lukasoppermann opened this issue Feb 23, 2018 · 5 comments
Labels
feature New feature or enhancement good first issue This issue should be easy for new contributors. If you need help please reach out to us! help wanted

Comments

@lukasoppermann
Copy link
Owner

lukasoppermann commented Feb 23, 2018

Convert the source file to typescript, which will be compiled in the rollup build step.
While we currently use .ts files, typehinting etc. is not used in the files.

If you want to help:
Just start adding typehints to any file that is still missing them or improve the ones that already have them. Feel free to send a PR for files even if only a part of them is converted.

@lukasoppermann lukasoppermann added the feature New feature or enhancement label Feb 23, 2018
@lukasoppermann lukasoppermann added feature New feature or enhancement help wanted good first issue This issue should be easy for new contributors. If you need help please reach out to us! and removed feature New feature or enhancement labels Mar 3, 2018
@3r3n-n
Copy link

3r3n-n commented Jun 9, 2021

Hi !
I see that this is an old issue but if there are still some files that need to be converted to TS, I’d be happy to help.

@lukasoppermann
Copy link
Owner Author

Hey, thank you, there are two important things concerning typescript:

  1. The PR to update fails Bump typescript from 4.2.4 to 4.3.2 #745 so this needs to be fixed (I didn't really check out what is the problem yet)
  2. The main file with everything that was not extracted to smaller modules yet is not using typings or other typescript features at all and could profit from it: https://github.com/lukasoppermann/html5sortable/blob/master/src/html5sortable.ts

If you want to work on either or both of those issues it would be very great.
You can also extract functionality from the html4sortable.ts into smaller modules where it makes sense and convert this over to typescript. This may be easier and more fun than in the big file.

@3r3n-n
Copy link

3r3n-n commented Jun 11, 2021

Great !
I am an OS newbie so I think I would be more comfortable trying the second option :)

@lukasoppermann
Copy link
Owner Author

Sounds great. Whatever you feel most comfortable with is a good start and very much appreciated. 👍

If you have questions, just send a PR and add a comment with your questions.

@lukasoppermann
Copy link
Owner Author

Stale

@lukasoppermann lukasoppermann closed this as not planned Won't fix, can't repro, duplicate, stale Aug 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or enhancement good first issue This issue should be easy for new contributors. If you need help please reach out to us! help wanted
Projects
None yet
Development

No branches or pull requests

2 participants