Layout::ON_TOP seems never used

[sergeyzozulya]

Hi and thanks for the component
It seem Layout::ON_TOP is a kind of placeholder for future use for now
Is that correct? Maybe I'm missing something

[lukas-frey]

Hi and thanks for the component
It seem Layout::ON_TOP is a kind of placeholder for future use for now
Is that correct? Maybe I'm missing something

Hi! Oh yeah, I've made a mistake when replacing the enum with constants to support php 8.0. I will release a quick fix today to fix it.

[lukas-frey]

Fixed it in the new release :)

[sergeyzozulya]

Unfortunately in 1.3.4 I cannot confirm it working...

Tried setting in config

'layout' => Guava\FilamentIconPicker\Layout::ON_TOP

Also tried this

IconPicker::make('icon')->layout(Layout::ON_TOP)

I don't see any difference between FLOATING and ON_TOP
I would expect is to show all icons when using ON_TOP

[sergeyzozulya]

Oops, my fault
It seems I had caching issue

[lukas-frey]

Oops, my fault
It seems I had caching issue

So does it work now? It did on my end. :) I had to rebuild the css, so that's probably why.

[sergeyzozulya]

Now I see the difference
When on ON_TOP is specified it doesn't hide the list

But I expected a grid with all icons by default so I don't have to type in anything