Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add shfmt parameters as optional inputs #3

Closed
luizm opened this issue Apr 1, 2020 · 8 comments
Closed

feat: add shfmt parameters as optional inputs #3

luizm opened this issue Apr 1, 2020 · 8 comments

Comments

@luizm
Copy link
Owner

luizm commented Apr 1, 2020

No description provided.

@jkroepke
Copy link
Contributor

👍
Since shfmt doesn't have config file support, this would be great.

@MaxPeal
Copy link

MaxPeal commented Jun 30, 2020

shfmt implemented EditorConfig support instead - see mvdan/sh#393 and the docs

@luizm can you add a support for this in the action?

@luizm
Copy link
Owner Author

luizm commented Jun 30, 2020

@luizm can you add support for this in the action?

Nice @MaxPeal

I think the only thing that we need to do is to update the shfmt version, and then it will check if the editorConfig exist and use then.

@MaxPeal
Copy link

MaxPeal commented Jun 30, 2020

BTW can you also add a shfmt parameters as optional args, like the SHELLCHECK_OPTS?

@luizm
Copy link
Owner Author

luizm commented Jun 30, 2020

BTW can you also add a shfmt parameters as optional args, like the SHELLCHECK_OPTS?

Yep, I will do that during this week :)

@IceCodeNew
Copy link

Would be great to see this improved in the next few days!
@luizm

@luizm
Copy link
Owner Author

luizm commented Sep 29, 2020

@IceCodeNew could you try this pre-release: https://github.com/luizm/action-sh-checker/releases/tag/v0.1.8?

@IceCodeNew
Copy link

@IceCodeNew could you try this pre-release: v0.1.8 (release)?

It works fine here, thank you for saving my day!

@luizm luizm closed this as completed Sep 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants