Handle watch-exec rollback correctly #119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luin
added a commit
that referenced
this pull request
Aug 3, 2015
Handle watch-exec rollback correctly
|
Cool! Released in 1.7.3 🍺 |
|
Wow, that was quick. Thanks so much for your help. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using WATCH/EXEC transactions in Redis, if the transaction rolls back (due to one of the watched keys being modified), the EXEC command does not return a result (instead of returning an array).
Currently this leads to
utils/wrapMultiResultfailing with aTypeError: Cannot read property 'length' of null.This PR adds tests for WATCH/EXEC (normal and rollback) and fixes the problem by making
wrapMultiResulta little more defensive.