Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(icons): Add toilet icon #2141

Merged
merged 22 commits into from
Nov 15, 2024
Merged

Conversation

EthanHazel
Copy link
Contributor

@EthanHazel EthanHazel commented May 9, 2024

Closes #1788

What is the purpose of this pull request?

  • New Icon
  • Bug fix
  • New Feature
  • Documentation update
  • Other:

Description

Creates a toilet icon SVG and JSON.

Icon use case

Can be used for things such as house / hotel listings to show the amount of bathrooms available.
Health related apps that could use it for medical related reasonings.
Maps showing you where the nearest bathroom is located.

Icon Design Checklist

Concept

  • I have provided valid use cases for each icon.
  • I have not added any a brand or logo icon.
  • I have not used any hate symbols.
  • I have not included any religious or political imagery.

Author, credits & license

  • The icons are solely my own creation.
  • The icons were originally created in # by @
  • I've based them on the following Lucide icons:
  • I've based them on the following design:

Naming

  • I've read and followed the naming conventions
  • I've named icons by what they are rather than their use case.
  • I've provided meta JSON files in icons/[iconName].json.

Design

  • I've read and followed the icon design guidelines
  • I've made sure that the icons look sharp on low DPI displays.
  • I've made sure that the icons look consistent with the icon set in size, optical volume and density.
  • I've made sure that the icons are visually centered.
  • I've correctly optimized all icons to three points of precision.

Before Submitting

@github-actions github-actions bot added 🎨 icon About new icons 🫧 metadata Improved metadata labels May 9, 2024
Copy link

github-actions bot commented May 9, 2024

Added or changed icons

icons/toilet.svg

Preview cohesion icons/message-square-lock.svg
icons/toilet.svg
icons/arrow-big-down.svg
Preview stroke widths icons/toilet.svg
icons/toilet.svg
icons/toilet.svg
DPI Preview (24px) icons/toilet.svg
Icon X-rays icons/toilet.svg
Icon Diffs icons/toilet.svg
Icons as code

Works for: lucide-react, lucide-react-native, lucide-preact, lucide-vue-next

const ToiletIcon = createLucideIcon('Toilet', [
  ["path",{"d":"M7 12h13a1 1 0 0 1 1 1 5 5 0 0 1-5 5h-.598a.5.5 0 0 0-.424.765l1.544 2.47a.5.5 0 0 1-.424.765H5.402a.5.5 0 0 1-.424-.765L7 18"}],
  ["path",{"d":"M8 18a5 5 0 0 1-5-5V4a2 2 0 0 1 2-2h8a2 2 0 0 1 2 2v8"}]
])

icons/toilet.svg Outdated Show resolved Hide resolved
Copy link

This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 5 days.

@github-actions github-actions bot added the Stale label Jul 15, 2024
@gorgobacka
Copy link

@EthanHazel Are you going to fix this?

@ericfennis Is the linting the only point that needs to be adjusted? And would it be possible to re-submit this PR using the same icon, if nothing happens in a reasonable time? I would like to see this icon in another app that is using this package.

@EthanHazel
Copy link
Contributor Author

@ericfennis Just fixed the formatting of the SVG, sorry for the late reply

@jguddas
Copy link
Member

jguddas commented Oct 4, 2024

More arcs:
icons
Open lucide studio

@github-actions github-actions bot added the 🌍 site Has to do something with the Lucide website label Oct 9, 2024
@EthanHazel
Copy link
Contributor Author

More arcs: iconsOpen lucide studio

Looks great! Added this version to the PR and added you to contributors

Copy link
Contributor Author

@EthanHazel EthanHazel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed issues related to naming and tags

@ericfennis ericfennis removed the Stale label Oct 28, 2024
@ericfennis
Copy link
Member

@EthanHazel Can you check the linter?

@EthanHazel
Copy link
Contributor Author

@EthanHazel Can you check the linter?

Just ran the prettier script and should pass fine now

Copy link
Member

@ericfennis ericfennis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice looks good now

Copy link
Contributor Author

@EthanHazel EthanHazel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

test

@ericfennis ericfennis changed the title Toilet Icon feat(icons): Add toilet icon Nov 15, 2024
@karsa-mistmere karsa-mistmere merged commit 4d91fbb into lucide-icons:main Nov 15, 2024
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🎨 icon About new icons 🫧 metadata Improved metadata 🌍 site Has to do something with the Lucide website
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Toilet
5 participants