Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add lightbulb-off icon #206

Merged
merged 3 commits into from
Apr 3, 2021

Conversation

mittalyashu
Copy link
Member

Preview
CleanShot 2021-02-03 at 22 25 14@2x

@ericfennis
Copy link
Member

@mittalyashu Looks a bit off, I think for one side of the slash you have to have 2px spacing, see other -off icons

@ericfennis ericfennis added the 🎨 icon About new icons label Feb 4, 2021
@mittalyashu
Copy link
Member Author

@ericfennis something like this?

Preview
CleanShot 2021-02-05 at 10 08 29@2x

@vercel
Copy link

vercel bot commented Feb 9, 2021

@mittalyashu is attempting to deploy a commit to the Lucide Team on Vercel.

A member of the Team first needs to authorize it.

@mittalyashu
Copy link
Member Author

@ericfennis fixed the icon

Copy link
Member

@ericfennis ericfennis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think It looks better if we extend the second bottom line a bit.
image

@mittalyashu
Copy link
Member Author

#206 (review)

You mean the first or second icon

@ericfennis
Copy link
Member

@mittalyashu the first one

@mittalyashu
Copy link
Member Author

okay, let me try.

@vercel
Copy link

vercel bot commented Apr 3, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/lucide/lucide/AJkqtAJGHfj5aapY72bHDGpQDpoz
✅ Preview: https://lucide-git-fork-mittalyashu-icon-lightbulb-off-lucide.vercel.app

Copy link
Member

@ericfennis ericfennis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice looks good!

@ericfennis ericfennis merged commit b131832 into lucide-icons:master Apr 3, 2021
@mittalyashu mittalyashu deleted the icon/lightbulb-off branch May 1, 2021 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🎨 icon About new icons
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants