Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(icons): added rounding to star icon #1987

Merged
merged 8 commits into from
Oct 28, 2024

Conversation

jguddas
Copy link
Member

@jguddas jguddas commented Mar 16, 2024

What is the purpose of this pull request?

  • Other: Icon update

Description

Added rounding

Before Submitting

@github-actions github-actions bot added 🎨 icon About new icons 🫧 metadata Improved metadata labels Mar 16, 2024
Copy link

github-actions bot commented Mar 16, 2024

Added or changed icons

icons/star-half.svgicons/star.svg

Preview cohesion icons/square-power.svgicons/message-square-dot.svg
icons/star-half.svgicons/star.svg
icons/hand-coins.svgicons/antenna.svg
Preview stroke widths icons/star-half.svgicons/star.svg
icons/star-half.svgicons/star.svg
icons/star-half.svgicons/star.svg
DPI Preview (24px) icons/star-half.svg icons/star.svg
Icon X-rays icons/star-half.svg icons/star.svg
Icon Diffs icons/star-half.svg icons/star.svg
Icons as code

Works for: lucide-react, lucide-react-native, lucide-preact, lucide-vue-next

const StarHalfIcon = createLucideIcon('StarHalf', [
  ["path",{"d":"M12 18.338a2.1 2.1 0 0 0-.987.244L6.396 21.01a.53.53 0 0 1-.77-.56l.881-5.139a2.12 2.12 0 0 0-.611-1.879L2.16 9.795a.53.53 0 0 1 .294-.906l5.165-.755a2.12 2.12 0 0 0 1.597-1.16l2.309-4.679A.53.53 0 0 1 12 2"}]
])

const StarIcon = createLucideIcon('Star', [
  ["path",{"d":"M11.525 2.295a.53.53 0 0 1 .95 0l2.31 4.679a2.123 2.123 0 0 0 1.595 1.16l5.166.756a.53.53 0 0 1 .294.904l-3.736 3.638a2.123 2.123 0 0 0-.611 1.878l.882 5.14a.53.53 0 0 1-.771.56l-4.618-2.428a2.122 2.122 0 0 0-1.973 0L6.396 21.01a.53.53 0 0 1-.77-.56l.881-5.139a2.122 2.122 0 0 0-.611-1.879L2.16 9.795a.53.53 0 0 1 .294-.906l5.165-.755a2.122 2.122 0 0 0 1.597-1.16z"}]
])

@karsa-mistmere
Copy link
Member

karsa-mistmere commented Mar 16, 2024

This could benefit from scaling it up for better visual weight allowed by the increased corner rounding.

Copy link
Member

@ericfennis ericfennis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jguddas Don't forget star-off and star-half, they should match the star icon 😊

@github-actions github-actions bot added the Stale label May 7, 2024
@jguddas jguddas marked this pull request as ready for review October 7, 2024 16:51
@lucide-icons lucide-icons deleted a comment from github-actions bot Oct 28, 2024
Copy link
Member

@ericfennis ericfennis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

star-half should be updated as well for consistency.

Copy link
Member

@ericfennis ericfennis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, nice work!

@ericfennis ericfennis merged commit 8cea9fe into lucide-icons:main Oct 28, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🎨 icon About new icons 🫧 metadata Improved metadata Stale
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants