-
-
Notifications
You must be signed in to change notification settings - Fork 681
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
We're not accepting new Brand icons #670
Comments
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as outdated.
This comment was marked as outdated.
Add google login to website lucide Icons has no Google icon, and as it turns out, they don't allow any new branch icons lucide-icons/lucide#670 and will be removing old ones. So only for logos of brands, we can use this new library, otherwise we stick to lucide
@mittalyashu @ericfennis @karsa-mistmere @jguddas Would adding a Markdown icon violate this? (even if an abstraction) |
@danielbayley markdown icon we should accept I think. Commonly used to indicate markdown fields for example. |
still a brand |
Kind of similar, if we start accepting library and framework logo's (React, Vue.js) |
@mittalyashu I don't think we should, React for one is objectively too detailed for our guidelines. |
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as abuse.
This comment was marked as abuse.
- provided by https://simpleicons.org - reason: Brand Icons are deprecated (lucide-icons/lucide#670)
While we very possible don't need further brand icons, should this library really deprecate all the existing brand icons? This is the only issue I have with this library. I don't want to add another library just to handle 1 or 2 situations. Every website will basically need the icon for Google, Instagram, X, and maybe Youtube, Linkedin, Whatsapp and Discord. There are surely many icons which have way lesser usefullness than a Google icon, for example, which is on virtually all the login screens on the web nowadays. |
You need to realise that unfortunately this is completely beyond our control. These are not just icons we're talking about; they are brand logos protected by copyright, and we cannot legally alter and redistribute them. Even if we did, they could be flagged for removal at any time, just as it happened in simple-icons/simple-icons#11236 |
Agree with the other comment. This should be mentioned on the website, rather than having every single developer using social icons go to your site, search for "twitter x" and so on, search github issues, go through several links, and finally land on this issue mentioning you aren't taking new icons. I don't blame you for not doing it due to legal issues, but it's such a waste of my time and other developers' time. |
Apparently, they're all the rage now… 🤦🏻♂️ |
Could this project not take the same stance as Microsoft has done with Cascadia Code Nerd Fonts and GitHub with Monaspace Nerd Fonts: https://github.com/githubnext/monaspace/releases/tag/v1.200 Basically include the logos in the package/font and if someone makes a fuss about it remove said icon at that time? Unless the icons are modified in such a way it no longer represents the brand I doubt many companies would care and might even be happy for the free advertising they get. |
The issue is that developers only realize an icon is deprecated after searching through GitHub issues or trying to use it in their projects. This creates unnecessary frustration and wasted time. Why not add a clear warning on the website itself? As I proposed in PR #2618, a simple notice would proactively inform developers before they even attempt to use a deprecated icon. |
Deprecated icons are already marked as such by our packages. 🤷♂️ If you do not use our packages, the SVG code you copy being deprecated should not make any difference. ![]() But again, we will add information about deprecated icons to the website, just not in the way it's proposed in #2618 and very definitely also not in the form of placing an ugly banner on the icons page as someone above suggested. |
Thank you for considering to add a new brand/company icon to Lucide. But, we're no longer accepting new brand icons.
To know more: feathericons/feather#763
We recommend using: https://github.com/simple-icons/simple-icons
We've an active issue for removal of existing brand icons, please do share your feedback.
The text was updated successfully, but these errors were encountered: