Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Offer filled icons for flutter / non-web platforms #407

Closed
prateekmedia opened this issue Sep 23, 2021 · 11 comments
Closed

Offer filled icons for flutter / non-web platforms #407

prateekmedia opened this issue Sep 23, 2021 · 11 comments

Comments

@prateekmedia
Copy link
Contributor

prateekmedia commented Sep 23, 2021

Icon Request

  • Icon name's: Thumbs up and down (other filled icons to consider => heart, star)
  • Use case: Currently lucide icons only have outlined icons even for some common filled icons too like thumbs up, but if someone wants to fill them in any case other then web like in flutter then they are bound to not been able to do so. It would be great if the flutter/ttf maintainer give some common filled icons to use.
  • Screenshots of similar icons:
    Below is the screen of youtube's like/dislike icons where thumbs up is filled and thumbs down is not
    Screenshot from 2021-09-23 12-57-48
@prateekmedia
Copy link
Contributor Author

Also, I know this might be done by using filled property of css in the web but I am using it on flutter and currently it doesn't have that feature and I am forced to use the outlined one.

@moeenio
Copy link
Contributor

moeenio commented Sep 25, 2021

I understand the need here, but I think this doesn't go with our design guidelines.

@prateekmedia
Copy link
Contributor Author

@locness3 I know this idea was discarded in feather icons due to the fact that we can fill the icons using css in web.

But I and many others are using this as a flutter package, which uses a ttf font, and hence no one can directly fill it. It would be great if the maintainer of that lucide_icons or the .ttf font gives us support of some common filled icons like thumbs up/down or other one's like heart and star.

@prateekmedia prateekmedia changed the title Add Thumbs up and down icons partially or fully filled for the sake of distinction Add some common filled icons for .ttf font / flutter package / non-web platforms Sep 25, 2021
@moeenio
Copy link
Contributor

moeenio commented Sep 26, 2021

That is to consider.

@prateekmedia prateekmedia changed the title Add some common filled icons for .ttf font / flutter package / non-web platforms Offer filled icons for flutter / non-web platforms Dec 11, 2021
@prateekmedia prateekmedia reopened this Dec 11, 2021
@moeenio
Copy link
Contributor

moeenio commented Dec 26, 2021

@ericfennis what do you think?

@ericfennis
Copy link
Member

@prateekmedia @locness3 I understand why you want this, and I agree would be nice to add these type of icons. But it is a whole new icon set what we then should create. We can't just add filled icons to the set. The project is not ready for this. Especially the build flows.

@karsa-mistmere
Copy link
Member

Totally just playing around here, but here's a small proof of concept of how I think multiple icon styles could be feasible while not having to create a filled/duotone version manually for every single icon using CSS classes: https://jsfiddle.net/cgd9a3h0/1/

@prateekmedia
Copy link
Contributor Author

@karsa-mistmere That was possible but please read the title of the issue, this is regarding flutter/non-web platform where we can't just use css rules.

@karsa-mistmere
Copy link
Member

I think it should still be feasible. Building separate styles should simply boil down to the build flow manipulating elements based on classes / custom attributes.

@frozencap
Copy link

imo this just boils down to creating separate icons for certain togglable buttons. Opening [Icon Request]

@karsa-mistmere
Copy link
Member

Filled/fillable icons are definitely something we might explore in the future, but we have a lot on our plates as it is, I'll close this for now and discussions can continue in #458.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants