-
-
Notifications
You must be signed in to change notification settings - Fork 532
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Offer filled icons for flutter / non-web platforms #407
Comments
Also, I know this might be done by using filled property of css in the web but I am using it on flutter and currently it doesn't have that feature and I am forced to use the outlined one. |
I understand the need here, but I think this doesn't go with our design guidelines. |
@locness3 I know this idea was discarded in feather icons due to the fact that we can fill the icons using css in web. But I and many others are using this as a flutter package, which uses a ttf font, and hence no one can directly fill it. It would be great if the maintainer of that |
That is to consider. |
@ericfennis what do you think? |
@prateekmedia @locness3 I understand why you want this, and I agree would be nice to add these type of icons. But it is a whole new icon set what we then should create. We can't just add filled icons to the set. The project is not ready for this. Especially the build flows. |
Totally just playing around here, but here's a small proof of concept of how I think multiple icon styles could be feasible while not having to create a filled/duotone version manually for every single icon using CSS classes: https://jsfiddle.net/cgd9a3h0/1/ |
@karsa-mistmere That was possible but please read the title of the issue, this is regarding flutter/non-web platform where we can't just use css rules. |
I think it should still be feasible. Building separate styles should simply boil down to the build flow manipulating elements based on classes / custom attributes. |
imo this just boils down to creating separate icons for certain togglable buttons. Opening [Icon Request] |
Filled/fillable icons are definitely something we might explore in the future, but we have a lot on our plates as it is, I'll close this for now and discussions can continue in #458. |
Icon Request
thumbs up
, but if someone wants to fill them in any case other then web like in flutter then they are bound to not been able to do so. It would be great if the flutter/ttf maintainer give some common filled icons to use.Below is the screen of youtube's like/dislike icons where thumbs up is filled and thumbs down is not
The text was updated successfully, but these errors were encountered: