Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Design discussion(/bug?): download-cloud & upload-cloud #268

Closed
wayne-shih opened this issue Mar 18, 2021 · 1 comment · Fixed by #271
Closed

Design discussion(/bug?): download-cloud & upload-cloud #268

wayne-shih opened this issue Mar 18, 2021 · 1 comment · Fixed by #271

Comments

@wayne-shih
Copy link

wondering if download-cloud and upload-cloud is the wrong way round?
If not, what was the intention behind it?

Screen Shot 2021-03-18 at 10 53 26 PM Screen Shot 2021-03-18 at 10 53 42 PM

rel: #246
cc: @ericfennis
@wayne-shih wayne-shih changed the title Design discussion(/potential bug?): download-cloud & upload-cloud Design discussion(/bug?): download-cloud & upload-cloud Mar 18, 2021
@ericfennis
Copy link
Member

@wayne-shih Welcome to the lucide project, thanks for this issue.

You're totally right, I think I switched them. Lucky we didn't released the new cloud icons yet.
I will create PR for it soon. Thanks!

@ericfennis ericfennis mentioned this issue Mar 20, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix cloud icons ericfennis/lucide
2 participants
@ericfennis @wayne-shih