Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Annotations cannot be undone by history #7

Closed
1 task
luccalb opened this issue Sep 4, 2023 · 2 comments
Closed
1 task

Annotations cannot be undone by history #7

luccalb opened this issue Sep 4, 2023 · 2 comments
Labels
wontfix This will not be worked on

Comments

@luccalb
Copy link
Owner

luccalb commented Sep 4, 2023

Currently the annotation changes are not tracked by the histories undo() and redo() commands. This is probably due to the fact that annotations are not stored inside the plugins storage field in the editor state but in an ordinary map.

  • Move the annotaitons map to the extensions storage field
@luccalb luccalb added the bug Something isn't working label Sep 4, 2023
@luccalb
Copy link
Owner Author

luccalb commented Sep 7, 2023 •
edited
Loading

The prosemirror history extension (which the tiptap history ist just a wrapper for) only tracks the history of the document, which annotations and decorations are not a part of. Therefore the current state is actually the expected behavior and not a bug.

@luccalb luccalb added the wontfix This will not be worked on label Sep 7, 2023
@luccalb
Copy link
Owner Author

luccalb commented Sep 7, 2023

Followup Issue: #9

@luccalb luccalb removed the bug Something isn't working label Sep 7, 2023
@luccalb luccalb closed this as not planned Won't fix, can't repro, duplicate, stale Sep 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
wontfix This will not be worked on
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@luccalb