You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Describe the bug
In BottomSheetView+Calculations.swift, in width(with:), the logic doesn't look right. If the iPad is in landscape mode, and you put the app in split screen mode, the code goes into UIDevice.current.orientation.isLandscape block and sets the bottom sheet width to %40 of the app width.
Minimal reproduce-able code
I paste the problematic function:
// For iPhone landscape, iPad and Mac support
func width(with geometry: GeometryProxy) -> CGFloat {
#if os(macOS)
// On Mac use 30% of the width
return geometry.size.width * 0.3
#else
if self.isIPadOrMac {
// On iPad use 30% of the width
return geometry.size.width * 0.3
} else if UIDevice.current.orientation.isLandscape {
// On iPhone landscape use of the 40% width
return geometry.size.width * 0.4
} else {
// On iPhone portrait use of the 100% width
return geometry.size.width
}
#endif
}
Expected behavior
I believe the sheet should follow the horizontal size class on iPad. The ideal would be to set a minimum width as an option.
Screenshots
Target version
Environment: iPad, Catalyst, iOS app on the Mac and macOS
Version: 15.6
The text was updated successfully, but these errors were encountered:
Describe the bug
In BottomSheetView+Calculations.swift, in
width(with:)
, the logic doesn't look right. If the iPad is in landscape mode, and you put the app in split screen mode, the code goes intoUIDevice.current.orientation.isLandscape
block and sets the bottom sheet width to %40 of the app width.Minimal reproduce-able code
I paste the problematic function:
Expected behavior
I believe the sheet should follow the horizontal size class on iPad. The ideal would be to set a minimum width as an option.
Screenshots
Target version
The text was updated successfully, but these errors were encountered: