Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace Reachability dependency with NWPathMonitor usage #406

Closed
GianniCarlo opened this issue Jun 21, 2022 · 4 comments
Closed

Replace Reachability dependency with NWPathMonitor usage #406

GianniCarlo opened this issue Jun 21, 2022 · 4 comments

Comments

@GianniCarlo
Copy link
Contributor

GianniCarlo commented Jun 21, 2022

Hi, I've been looking into integrating this library into my project, with the purpose of using it across iOS and watchOS. Xcode won't build the watchOS target due to the Reachability dependency, which uses SystemConfiguration as stated in #379 (no matter if I use anything related to reachability or not, just including it in my watchOS target fails to compile)

Screen Shot 2022-06-21 at 08 41 23

Would you be interested in a PR replacing the use of Reachability for NWPathMonitor from the Network framework which is available on all platforms (although the targets are higher: iOS 12+, macOS 10.14+, watchOS 5.0+, etc)?

I saw one article from Hacking with Swift and the usage looks pretty straight forward, and it also makes available the isExpensive flag for connections

@lucas34
Copy link
Owner

lucas34 commented Jun 22, 2022

Sure I have been looking at dropping reachability.
Feel free to send a Pull Request

@lucas34
Copy link
Owner

lucas34 commented Jun 26, 2022

@GianniCarlo I have merged it. Thanks for your contribution.
I'll make additional testing and will release a new version. Probably 6.0

@lucas34 lucas34 closed this as completed Jun 26, 2022
@GianniCarlo
Copy link
Contributor Author

Awesome! let me know if I can be of any help 👍

@github-actions github-actions bot mentioned this issue Jun 29, 2022
@lucas34
Copy link
Owner

lucas34 commented Jun 29, 2022

@GianniCarlo 6.0.0 is released. Let me know if everything works fine.
Appreciate your contribution.

@github-actions github-actions bot mentioned this issue Sep 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants