Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

trace and qlog version selection / negotiation #3153

Merged
merged 1 commit into from
Apr 28, 2021

Conversation

marten-seemann
Copy link
Member

#3109 removed the version information from the connection_started event. This PR now implements support for the version_information event.

@marten-seemann marten-seemann force-pushed the trace-version-selection branch from 09f3996 to e7c4e75 Compare April 19, 2021 04:38
@codecov
Copy link

codecov bot commented Apr 19, 2021

Codecov Report

Merging #3153 (e7c4e75) into master (3138a45) will increase coverage by 0.05%.
The diff coverage is 96.97%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3153      +/-   ##
==========================================
+ Coverage   85.38%   85.43%   +0.05%     
==========================================
  Files         131      131              
  Lines        9684     9717      +33     
==========================================
+ Hits         8268     8301      +33     
  Misses       1046     1046              
  Partials      370      370              
Impacted Files Coverage Δ
logging/multiplex.go 95.24% <0.00%> (-2.32%) ⬇️
qlog/event.go 98.00% <100.00%> (+0.08%) ⬆️
qlog/qlog.go 91.07% <100.00%> (+0.47%) ⬆️
session.go 77.41% <100.00%> (+0.22%) ⬆️
internal/utils/rand.go 75.00% <0.00%> (+12.50%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3138a45...e7c4e75. Read the comment docs.

@marten-seemann marten-seemann merged commit 0413afd into master Apr 28, 2021
@marten-seemann marten-seemann deleted the trace-version-selection branch May 1, 2021 02:22
@aschmahmann aschmahmann mentioned this pull request May 14, 2021
71 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants