Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

don't regard PMTU probe packets as outstanding #3126

Merged
merged 1 commit into from
Apr 2, 2021

Conversation

marten-seemann
Copy link
Member

@marten-seemann marten-seemann commented Mar 26, 2021

This also means that PMTU probe packets won't be declared lost when the PTO timer expires.

This also means that PMTU probe packets won't be sent as PTO probe packets.
@codecov
Copy link

codecov bot commented Mar 26, 2021

Codecov Report

Merging #3126 (5bdbff9) into master (81d16a9) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3126      +/-   ##
==========================================
+ Coverage   85.47%   85.48%   +0.01%     
==========================================
  Files         131      131              
  Lines        9650     9651       +1     
==========================================
+ Hits         8248     8250       +2     
+ Misses       1034     1033       -1     
  Partials      368      368              
Impacted Files Coverage Δ
internal/ackhandler/sent_packet_history.go 95.83% <100.00%> (+0.09%) ⬆️
internal/utils/rand.go 75.00% <0.00%> (+12.50%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 81d16a9...5bdbff9. Read the comment docs.

@marten-seemann marten-seemann merged commit 37a3938 into master Apr 2, 2021
@marten-seemann marten-seemann deleted the dont-pto-pmtu-packets branch April 2, 2021 10:41
@aschmahmann aschmahmann mentioned this pull request May 14, 2021
71 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants