fix calculation of the handshake idle timeout #3120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lucas-clemente
approved these changes
Apr 2, 2021
marten-seemann
force-pushed
the
fix-handshake-idle-timeout
branch
from
941c766
to
63e810f
Compare
Codecov Report
@@ Coverage Diff @@
## master #3120 +/- ##
==========================================
+ Coverage 85.38% 85.68% +0.31%
==========================================
Files 131 131
Lines 9671 9940 +269
==========================================
+ Hits 8257 8517 +260
- Misses 1045 1060 +15
+ Partials 369 363 -6
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This could lead to busy-looping (until the handshake timeout kicks in).