improve string representation of timeout errors #3118
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, an idle timeout's string representation is
NO_ERROR: No recent network activity
. With this PR, it will beTimeout: No recent network activity
.Note that this will break some applications building on top of quic-go that are performing string matching to detect timeout errors. I don't see this as a problem with this PR though, I regard this as a feature.
While it is true that our errors are not as helpful as they could be (see #2441), detecting timeout errors is not a problem: Our errors implement the
net.Error
interface, which defines aTimeout() bool
method.