Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

don't pass the QUIC version to the StartedConnection event #3109

Merged
merged 2 commits into from
Apr 2, 2021

Conversation

marten-seemann
Copy link
Member

The version might change in response to a Version Negotiation packet.

@marten-seemann marten-seemann force-pushed the version-negotiation-logging branch 2 times, most recently from f14630e to a311932 Compare March 22, 2021 06:55
@codecov
Copy link

codecov bot commented Mar 22, 2021

Codecov Report

Merging #3109 (22daaf4) into master (ea14ce5) will increase coverage by 0.12%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3109      +/-   ##
==========================================
+ Coverage   85.45%   85.57%   +0.12%     
==========================================
  Files         131      131              
  Lines        9657    10280     +623     
==========================================
+ Hits         8252     8797     +545     
- Misses       1036     1063      +27     
- Partials      369      420      +51     
Impacted Files Coverage Δ
qlog/event.go 97.92% <ø> (-0.01%) ⬇️
qlog/qlog.go 90.60% <ø> (-0.04%) ⬇️
client.go 78.33% <100.00%> (ø)
logging/multiplex.go 97.56% <100.00%> (ø)
session.go 79.23% <100.00%> (+2.12%) ⬆️
internal/ackhandler/ackhandler.go 0.00% <0.00%> (ø)
internal/congestion/cubic_sender.go 88.70% <0.00%> (+2.09%) ⬆️
internal/ackhandler/sent_packet_handler.go 81.71% <0.00%> (+4.46%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ea14ce5...22daaf4. Read the comment docs.

@marten-seemann marten-seemann merged commit e3f36af into master Apr 2, 2021
@marten-seemann marten-seemann deleted the version-negotiation-logging branch April 3, 2021 01:34
@aschmahmann aschmahmann mentioned this pull request May 14, 2021
71 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants