Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

only accept 0-RTT it the active_connection_id_limit didn't change #3060

Merged
merged 1 commit into from
Mar 9, 2021

Conversation

marten-seemann
Copy link
Member

As discovered by @rip-create-your-account in #3058 (comment), we need to check that the active_connection_id_limit transport parameter didn't change when accepting 0-RTT.

@codecov
Copy link

codecov bot commented Mar 3, 2021

Codecov Report

Merging #3060 (35da77a) into master (2c45f2b) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3060   +/-   ##
=======================================
  Coverage   86.16%   86.16%           
=======================================
  Files         132      132           
  Lines        9355     9356    +1     
=======================================
+ Hits         8060     8061    +1     
  Misses        938      938           
  Partials      357      357           
Impacted Files Coverage Δ
internal/wire/transport_parameters.go 89.08% <100.00%> (+0.05%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2c45f2b...35da77a. Read the comment docs.

@rip-create-your-account
Copy link

There's a tricky bug here which occurs when the client has already sent the NewConnectionIDFrames based on the 0-RTT (*TransportParameters).ActiveConnectionIDLimit. If the server has reduced its limit it will with this PR reject the 0-RTT handshake. When the client is notified that the 0-RTT handshake was rejected, it will drop the 0-RTT packets. This means that it will end up retransmitting the NewConnectionIDFrames of the 0-RTT packets, which is too many of them.

@marten-seemann
Copy link
Member Author

@rip-create-your-account That's #2067.

@marten-seemann marten-seemann merged commit c802ebe into master Mar 9, 2021
@marten-seemann marten-seemann deleted the check-active-conn-id-limit-for-0rtt branch March 9, 2021 07:59
@aschmahmann aschmahmann mentioned this pull request May 14, 2021
71 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants