immediately complete streams that were canceled, drop retransmissions #3003
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marten-seemann
force-pushed
the
fix-stream-cancellation
branch
from
cf54e0b
to
91d6167
Compare
marten-seemann
force-pushed
the
fix-stream-cancellation
branch
from
91d6167
to
b5615db
Compare
Codecov Report
@@ Coverage Diff @@
## master #3003 +/- ##
==========================================
+ Coverage 86.06% 86.08% +0.01%
==========================================
Files 135 135
Lines 9415 9423 +8
==========================================
+ Hits 8103 8111 +8
Misses 953 953
Partials 359 359
Continue to review full report at Codecov.
|
|
Looks good to me. I agree that the immediate completion is better. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3002.
@rip-create-your-acccount Would be great if you could review this PR!