Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

don't retransmit PING frames added to ACK-only packets #2942

Merged
merged 1 commit into from
Dec 22, 2020

Conversation

marten-seemann
Copy link
Member

Every 20 non-ack-eliciting packets, we add a PING frame to make that packet ack-eliciting. That way, we regularly receive acknowledgements, even if we're not actually sending any data. This allows us to clean up our sent packet history.

There's no need to retransmit this PING frame though. We'll just send a new one if one of them is lost, as soon as we've sent another 20 non-ack-eliciting packets.

Every 20 non-ack-eliciting packets, we add a PING frame to make that
packet ack-eliciting. That way, we regularly receive acknowledgements,
even if we're not actually sending any data. This allows us to clean up
our sent packet history.
There's no need to retransmit this PING frame though. We'll just send a
new one if one of them is lost, as soon as we've sent another 20
non-ack-eliciting packets.
@codecov
Copy link

codecov bot commented Dec 17, 2020

Codecov Report

Merging #2942 (d8858d7) into master (9693a46) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2942      +/-   ##
==========================================
- Coverage   86.04%   86.03%   -0.01%     
==========================================
  Files         134      134              
  Lines        9286     9286              
==========================================
- Hits         7990     7989       -1     
  Misses        938      938              
- Partials      358      359       +1     
Impacted Files Coverage Δ
packet_packer.go 84.30% <0.00%> (-0.21%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9693a46...d8858d7. Read the comment docs.

@marten-seemann marten-seemann merged commit 9f6d1f5 into master Dec 22, 2020
@marten-seemann marten-seemann deleted the dont-retransmit-ack-only-pings branch December 23, 2020 08:03
@aschmahmann aschmahmann mentioned this pull request May 14, 2021
71 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants