Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reduce the maximum number of ACK ranges #2887

Merged
merged 1 commit into from
Dec 5, 2020

Conversation

marten-seemann
Copy link
Member

This is basically a prerequisite for #2885, as we'll keep ACK frames with []wire.AckRange in the buffer.

Imagine the worst-case scenario here: We're receiving every packet with a gap after the last packet (e.g. packet numbers 2, 4, 6, 8, ...). Every out-of-order packet will elicit an ACK frame, so we'll send out every ACK range in 31 ACK frames (assuming we're not getting an ACK back that clears those ranges). This is assuming that we're not processing packets faster than we send out ACKs (the select in the session run loop is not deterministic).

@codecov
Copy link

codecov bot commented Nov 20, 2020

Codecov Report

Merging #2887 (33c7588) into master (69158cf) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2887   +/-   ##
=======================================
  Coverage   85.77%   85.77%           
=======================================
  Files         133      133           
  Lines        9187     9187           
=======================================
  Hits         7880     7880           
  Misses        959      959           
  Partials      348      348           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 69158cf...33c7588. Read the comment docs.

@marten-seemann marten-seemann merged commit eae8ad2 into master Dec 5, 2020
@marten-seemann marten-seemann deleted the reduce-num-ack-ranges branch December 6, 2020 02:47
@aschmahmann aschmahmann mentioned this pull request May 14, 2021
71 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants