reduce the maximum number of ACK ranges #2887
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is basically a prerequisite for #2885, as we'll keep ACK frames with
[]wire.AckRange
in the buffer.Imagine the worst-case scenario here: We're receiving every packet with a gap after the last packet (e.g. packet numbers 2, 4, 6, 8, ...). Every out-of-order packet will elicit an ACK frame, so we'll send out every ACK range in 31 ACK frames (assuming we're not getting an ACK back that clears those ranges). This is assuming that we're not processing packets faster than we send out ACKs (the
select
in the session run loop is not deterministic).