qlog tokens in NEW_TOKEN frames, Retry packets and Initial packets #2863
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2863 +/- ##
==========================================
+ Coverage 86.22% 86.23% +0.01%
==========================================
Files 133 133
Lines 9127 9133 +6
==========================================
+ Hits 7869 7875 +6
Misses 909 909
Partials 349 349
Continue to review full report at Codecov.
|
marten-seemann
changed the title
lucas-clemente
approved these changes
Nov 10, 2020
| @@ -130,8 +130,7 @@ func marshalCryptoFrame(enc *gojay.Encoder, f *logging.CryptoFrame) { | |||
|
|
|||
| func marshalNewTokenFrame(enc *gojay.Encoder, f *logging.NewTokenFrame) { | |||
| enc.StringKey("frame_type", "new_token") | |||
| enc.IntKey("length", len(f.Token)) | |||
| enc.StringKey("token", fmt.Sprintf("%x", f.Token)) | |||
| enc.ObjectKey("token", &token{Raw: f.Token}) | |||
There was a problem hiding this comment.
how sensitive is the token, should it appear in logs?
There was a problem hiding this comment.
Not very sensitive. All you can do with is initiate a new connection with a lower risk of receiving a Retry.
Also, you could correlate two connections.
marten-seemann
force-pushed
the
qlog-token-logging
branch
from
d196634
to
b83e156
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.