implement tracing for congestion state changes #2684
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2684 +/- ##
==========================================
- Coverage 86.77% 86.75% -0.02%
==========================================
Files 124 124
Lines 9869 9907 +38
==========================================
+ Hits 8563 8594 +31
- Misses 974 980 +6
- Partials 332 333 +1
Continue to review full report at Codecov.
|
marten-seemann
force-pushed
the
trace-congestion-events
branch
2 times, most recently
from
57b9571
to
ff59c16
Compare
lucas-clemente
approved these changes
Jul 22, 2020
The RTTStats are used by the logging package. In order to instrument the congestion package, the RTTStats can't be part of that package any more (to avoid an import loop).
marten-seemann
force-pushed
the
trace-congestion-events
branch
from
ff59c16
to
5cf72e2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.