Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

don't send write error in CONNECTION_CLOSE frames #2666

Merged
merged 1 commit into from
Jul 10, 2020

Conversation

marten-seemann
Copy link
Member

If the send queue already failed, there's no point in trying to send out a CONNECTION_CLOSE.

@codecov
Copy link

codecov bot commented Jul 9, 2020

Codecov Report

Merging #2666 into master will increase coverage by 0.06%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2666      +/-   ##
==========================================
+ Coverage   86.44%   86.50%   +0.06%     
==========================================
  Files         122      122              
  Lines        9763     9763              
==========================================
+ Hits         8439     8445       +6     
+ Misses        989      986       -3     
+ Partials      335      332       -3     
Impacted Files Coverage Δ
session.go 77.07% <100.00%> (+0.40%) ⬆️
send_queue.go 100.00% <0.00%> (+7.69%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 953f347...61d8e11. Read the comment docs.

@marten-seemann marten-seemann merged commit 76c854f into master Jul 10, 2020
@marten-seemann marten-seemann deleted the dont-send-write-errors branch July 10, 2020 11:23
@aschmahmann aschmahmann mentioned this pull request Sep 22, 2020
72 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants