Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Assigning px values to snapDestination is not working #34

Closed
lucafalasco opened this issue Jan 22, 2021 · 0 comments · Fixed by #35
Closed

Assigning px values to snapDestination is not working #34

lucafalasco opened this issue Jan 22, 2021 · 0 comments · Fixed by #35
Assignees
@lucafalasco
Labels
bug

Comments

@lucafalasco
Copy link
Owner

Passing a pixel value as snapDestination doesn't currently work as expected:

snapDestinationY: '980px',

We should also accept numeric values

snapDestinationY: 980
@lucafalasco lucafalasco self-assigned this Jan 22, 2021
lucafalasco added a commit that referenced this issue Jan 22, 2021
@lucafalasco
Fix px values handling in snapDestination
ad49538 
Fixes #34 , handle numeric input, general refactor
@lucafalasco lucafalasco mentioned this issue Jan 22, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lucafalasco lucafalasco

Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix px values handling in snapDestination lucafalasco/scroll-snap
1 participant
@lucafalasco