We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
byte[]
The byte array based API does all the work in JNI critical sections (e.g.
zstd-jni/src/main/native/jni_fast_zstd.c
Line 488 in 9b39b59
This is liable to cause OOM crashes when using that with G1 GC without region pinning https://openjdk.org/jeps/423, i.e. in a runtime before java 22.
I think a warning in the docs would be appropriate.
Or one could allocate a temp buffer in the C world, and only hold the critical section for the time of a memcpy.
memcpy
PS. some other background: https://shipilev.net/jvm/anatomy-quarks/9-jni-critical-gclocker/
The text was updated successfully, but these errors were encountered:
No branches or pull requests
The byte array based API does all the work in JNI critical sections (e.g.
zstd-jni/src/main/native/jni_fast_zstd.c
Line 488 in 9b39b59
This is liable to cause OOM crashes when using that with G1 GC without region pinning https://openjdk.org/jeps/423, i.e. in a runtime before java 22.
I think a warning in the docs would be appropriate.
Or one could allocate a temp buffer in the C world, and only hold the critical section for the time of a
memcpy
.PS. some other background: https://shipilev.net/jvm/anatomy-quarks/9-jni-critical-gclocker/
The text was updated successfully, but these errors were encountered: