Skip to content
This repository has been archived by the owner on Nov 20, 2023. It is now read-only.

Selecting of a visible event in the event table result in a move of the event table #65

Open
PSRCode opened this issue Feb 16, 2018 · 2 comments
Labels
bug Issue is an acknowledged bug, should be fixed

Comments

@PSRCode
Copy link
Contributor

PSRCode commented Feb 16, 2018

1- Do a selection inside the thread view
2- The event table will update to the selection
3- Click on a visible event in the event table
4- Other view update
5- The event table will move even if it is not necessary.

@PSRCode
Copy link
Contributor Author

PSRCode commented Feb 16, 2018

Not sure if a bug ... in the end ... it was less obvious that it is refreshed to place the selected event in the middle of the view. In a small view it looks weird.

We might want to revisit how we do this.

@ghost
Copy link

ghost commented Feb 19, 2018

Yeah it's a known limitation of the current implementation. Turns out that it is not straightforward to determine "is the selected event currently in the visible table area?". It should be doable, but would probably require tracking the scrollbar position by ourselves.

For now I just had it recenter on every selection. But it's a very valid comment, if the new selection is already visible then it should not recenter.

@ghost ghost added the bug Issue is an acknowledged bug, should be fixed label Feb 19, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue is an acknowledged bug, should be fixed
Projects
None yet
Development

No branches or pull requests

1 participant