Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve localization #115

Open
amadeous opened this issue Jun 25, 2024 · 1 comment
Open

Improve localization #115

amadeous opened this issue Jun 25, 2024 · 1 comment

Comments

@amadeous
Copy link
Contributor

When displaying details about a serie, it seems that the airday is not localized (except "Daily"). Could we add this to the localized strings?

Additionally, could we do something about the airtime? It is currently displayed as "HH:MM AM/PM". It would be nice to have that localized according to the user's preference. It seems that the is24HourFormat function can be used for that.

I could make a PR with the proposed changes.
However, I wanted to make sure that there is an interest for these small modifications.

@ltguillaume
Copy link
Owner

ltguillaume commented Jun 26, 2024

Those changes make sense. If you make a PR, it'll be merged 🙂

If you happen to have a Codeberg account, please make the PR there, it'll be a lot easier for me, since this here is just a mirror now.

https://codeberg.org/ltguillaume/droidshows

Thanks in advance!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants