Poor visibility on white background

[vi]

Expected behavior

When running on white terminal background, lsd detects it and changes colour scheme appropriately. Alternatively, there is something like --color-theme=white-background option. Or just only those colours that are suitable on any background are used.

Actual behavior

[Peltoche]

Hi @vi ,

Here the list of possible solutions:

• Use the LS_COLORS env variable.
• Use the ANSI colors (discussed in Use terminal color scheme #90).
• Wait for a solution like Themes #92 to land
• Create the --color-theme flag but I'm not a fan to hardcode a list of theme inside the binary.

[vi]

LS_COLORS seem to be about file types. And filename colours are already mostly OK-ish.

How do I set column, mode and time colours in LS_COLORS? Are there custom lsd-specific fields?

[Peltoche]

How do I set column, mode and time colours in LS_COLORS? Are there custom lsd-specific fields?

Nop, we don't have this yet. So the LS_COLORS doesn't solve you issue.

[meain]

Related #90

[erlanger]

I am having this problem also, and I bet many people too. I hope a fix is posted soon.

[vultix]

This is a blocker for me using replacing ls with lsd at the moment. I'm super busy at the moment, but will look into a solution this weekend if I get some free time.

[Svetlitski]

Any progress on this, or pointers on how to get started fixing this (if it's amenable to a newcomer I may be interested in working on it)?

[meain]

@Svetlitski There is a solution to this at #317 but both of us a bit busy to review and merge a big PR like that right now.

A simple solution would be to implement something similar to what is discussed in #90 for all items, One issue with that is we have gradient colors for both size and date, and it is not easy to find a replacement which might works for both light and dark with simple ANSI colors, I think.
If would could get something that works, we could probably merge that in.

I think if we were to go this route, we will have to replace the defined colors with color values below 15. The function is named get_light_color_theme, but that is the only function that is called to get a color theme.

NOTE: The colors of filenames and folders are taken care of already, it is the other colors like the one for size, permission etc that is causing the trouble.

[meain]

@Peltoche what is your opinion on have a light and minimal variant in the binary? This could be obsolete once the config option lands though.

[gitaarik]

I think a default light and dark theme shipped in the binary would be great, since having both a dark an light theme is becoming more and more common in all kinds of applications.

[sisrfeng]

Wait for support for light color theme!

[Jerror]

Still a blocker for all of us using light themes. The long listing format is only legible on light with --color=never, but that drops the file colorization. How about an option which disables colors of everything except files? I believe that would replicate the coloring of ls exactly, so that lsd with this flag would essentially be "ls with icons." Maybe call it colors=classic.

This would resolve the issue for potential light-theme users until light theme support is implemented and may entice users who would like to use lsd for the icons but are tripped out by all the colors.

[meain]

lsd now has support for theming as of #452. It is not yet in a release, but will be soon. Combined with LS_COLORS, lsd should now be completely usable in a light terminal.

I personally prefer a minimal colorscheme, you can use mine if you are interested. Maybe we can start a wiki page with popular themes if there is enough interest.

my personal theme

[gitaarik]

Nice work! I am exited to try it out soon :)

[aanari]

This was an easy fix for me:

[zwpaper]

I am closing this since we now support color theme

/close