Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: Fix mend security issues #356

Merged
merged 9 commits into from
Feb 5, 2025
Merged

Conversation

FelberMartin
Copy link
Collaborator

@FelberMartin FelberMartin commented Jan 28, 2025

Problem Description

The have been multiple security issues opened by mend, most of which are tackled in this PR.

This closes #340, #339, #338, #337, #336, #335, #334, #333, #332, #331, #234, #177, #176. #175, #83, and #80

Changes

  • Exclude unused dependencies that cause security problems.

Steps for testing

The app works without any problems.
Specifically:

  • Firebase dependencies: Push notifications
  • DataStore: Storing data locally (eg the collapsed state of conversation sections, code of conduct state)

Verified

This commit was signed with the committer’s verified signature.
SimonBrandner Šimon Brandner
FelberMartin and others added 3 commits January 29, 2025 15:12
Copy link
Contributor

@julian-wls julian-wls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did test the functionality and didn't notice any difference, receiving notifications worked fine, really nice to have all these issues closed after merging.
Code lgtm!

@FelberMartin FelberMartin added ready to merge This PR can be merged and removed ready for review This PR can be reviewed labels Feb 5, 2025
@FelberMartin FelberMartin merged commit 4713327 into develop Feb 5, 2025
5 checks passed
@FelberMartin FelberMartin deleted the chore/fix-mend-issues-01 branch February 5, 2025 21:13
FelberMartin added a commit that referenced this pull request Feb 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment