Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix: Add workaround for notifaction for own answer #372

Conversation

FelberMartin
Copy link
Collaborator

Problem Description

The user would get a notification when replying to its own post in a non-DM chat.

While the root cause for this is on the server-side, I decided to add a workaround for the meantime.

This closes #326

Changes

  • Check whether author of post notification is the app user and discard the notification in this case

Steps for testing

  • In the Android app enable notifications for test_user_1
  • On the web app, create a post in a channel with test_user_1
  • -> No notification on the android app
  • On the web app, create a new answer post to the latter post (using test_user_1 again)
  • -> Notice that no notification is received anymore for own answer post

@FelberMartin FelberMartin added the ready for review This PR can be reviewed label Feb 1, 2025
@FelberMartin FelberMartin self-assigned this Feb 1, 2025
Copy link
Contributor

@julian-wls julian-wls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Both scenarios worked as expected for me.
Code lgtm.

@FelberMartin FelberMartin added ready to merge This PR can be merged and removed ready for review This PR can be reviewed labels Feb 5, 2025
@FelberMartin FelberMartin merged commit c2d50df into develop Feb 5, 2025
5 checks passed
@FelberMartin FelberMartin deleted the bugfix/communication/workaround-notifaction-for-own-answer branch February 5, 2025 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge This PR can be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Notification for own answer post
2 participants