Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Branch search format breaking #286

Merged
merged 4 commits into from
Feb 3, 2025
Merged

Conversation

egekocabas
Copy link
Member

@egekocabas egekocabas commented Jan 30, 2025

Motivation

Refer to #285

Screenshots

I made a change to style to prevent centering only the highlighted part when the branch name doesn't fit to the screen, after changes, it looks like below:

It doesn't feel like the current changes is the solution but it got better then the existing one. This huge branch names also causes the icons to change sizes, that is also another issue

Screen.Recording.2025-02-02.at.21.07.38.mov

@github-actions github-actions bot added bug Something isn't working client size:XS labels Jan 30, 2025
Copy link

codacy-production bot commented Jan 30, 2025

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
Report missing for 17fe59e1
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (17fe59e) Report Missing Report Missing Report Missing
Head commit (560fd91) 835 272 32.57%

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#286) 0 0 ∅ (not applicable)

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

Footnotes

  1. Codacy didn't receive coverage data for the commit, or there was an error processing the received data. Check your integration for errors and validate that your coverage setup is correct.

@egekocabas egekocabas linked an issue Jan 30, 2025 that may be closed by this pull request
@github-actions github-actions bot added size:S and removed size:XS labels Feb 2, 2025
@egekocabas
Copy link
Member Author

I have used the mark tag but the problem i was trying to mention is not related with it actually, so i uploaded the final version can somebody check it out? @ls1intum/helios

@egekocabas egekocabas marked this pull request as ready for review February 2, 2025 20:09
@egekocabas egekocabas requested a review from a team as a code owner February 2, 2025 20:09
Copy link
Contributor

@TurkerKoc TurkerKoc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for addressing the problems! Maybe not the best but better than the previous version. Let's fix this issue in another later on!

@TurkerKoc TurkerKoc merged commit 0d1e309 into main Feb 3, 2025
15 checks passed
@TurkerKoc TurkerKoc deleted the fix/branch-search-format branch February 3, 2025 02:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Branch name format issues after branch search
2 participants