Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Making Deployment flexible #266

Closed
thielpa opened this issue Jan 21, 2025 · 2 comments · Fixed by #273
Closed

Making Deployment flexible #266

thielpa opened this issue Jan 21, 2025 · 2 comments · Fixed by #273
Assignees
Labels

Comments

@thielpa
Copy link
Contributor

thielpa commented Jan 21, 2025

User story:
As a user I want to be not locked in deploying only via Helios, but if Helios is down also deploy manually.

Demo:

  1. Deployment via Helios:
    a) Click on Artemis
    b) Click deploy
    c) Go to environment url -> see its deployed
  2. Deployment via Github:
    a) Go to GitHub Action
    b) Click manually deploy
    c) Go to environment url -> see its deployed

⚠ Risks:

  • Someone can bypass the locking mechanism via manual deployment
  • Someone can deploy to prod without security checks
@egekocabas
Copy link
Contributor

Sent a message to Timor and waiting his opinion about only using workflow_dispatch without any deployment_protection_rules.

@egekocabas
Copy link
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants