Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Warn user before reload when in exam mode #10142

Open
simonbohnen opened this issue Jan 13, 2025 · 4 comments · May be fixed by #10193
Open

Warn user before reload when in exam mode #10142

simonbohnen opened this issue Jan 13, 2025 · 4 comments · May be fixed by #10193
Assignees
@badkeyy
Labels
exam Pull requests that affect the corresponding module feature

Comments

@simonbohnen
Copy link

Is your feature request related to a problem?

When in exam mode, there is no warning before a reload of the page. All unsaved changes are lost.

Describe the solution you'd like

It would be nice to have an alert before a reload.

Describe alternatives you've considered

No response

Additional context

Discovered together with @coolchock.
@github-actions github-actions bot added the exam Pull requests that affect the corresponding module label Jan 13, 2025
@simonbohnen simonbohnen changed the title Warn user before reload when in exam mode. Warn user before reload when in exam mode Jan 13, 2025
@krusche
Copy link
Member

krusche commented Jan 13, 2025

We used to have this feature. I'm wondering what happened to it?

@badkeyy badkeyy self-assigned this Jan 22, 2025
@badkeyy
Copy link
Contributor

badkeyy commented Jan 22, 2025

For me this still works (See Screenshot). In which browser did you test this?

Image

@simonbohnen
Copy link
Author

simonbohnen commented Jan 22, 2025 •
edited
Loading

I tested it just now in a test exam in both Chrome and Arc, and when I press Cmd+R it doesn't show a warning.
Last time I tested it in a "real" exam, also both in Chrome and Arc I thing.

@badkeyy
Copy link
Contributor

badkeyy commented Jan 22, 2025 •
edited
Loading

Ah yes you are right I confused myself by already testing my fix - sorry (I was confused because it did not show my custom message in the popup and therefore I thought this is already implemented). I will open up a PR.

@badkeyy badkeyy linked a pull request Jan 22, 2025 that will close this issue
Open
22 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@badkeyy badkeyy

Labels
exam Pull requests that affect the corresponding module feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Exam mode: Warn user before reloading the page ls1intum/Artemis
3 participants
@krusche @badkeyy @simonbohnen