Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Result export does not work #10000

Closed
b-fein opened this issue Dec 11, 2024 · 0 comments · Fixed by #10174
Closed

Result export does not work #10000

b-fein opened this issue Dec 11, 2024 · 0 comments · Fixed by #10174
Assignees
Labels
assessment Pull requests that affect the corresponding module bug client Pull requests that update TypeScript code. (Added Automatically!) exercise Pull requests that affect the corresponding module programming Pull requests that affect the corresponding module

Comments

@b-fein
Copy link
Contributor

b-fein commented Dec 11, 2024

Describe the bug

Exporting the results for an exercise that has manual assessment and grading instructions does not work.

To Reproduce

Preconditions:

  • An exercise with manual assessments and grading instructions.
    • In our case the issue occurs in a programming exercise. Might happen for other exercise types as well.
  • One student submission that has been manually assessed while using grading instructions for the manually added feedback.
  1. Go to the scores list for the exercise.
  2. Top right: Export > Export Results.
  3. None of the three options work.

Expected behavior

The CSV is exported.

Screenshots

No response

Which version of Artemis are you seeing the problem on?

7.7.4

What browsers are you seeing the problem on?

Firefox

Additional context

It occurred with a programming exercise for us. Not sure if also applicable to other exercise types.

Relevant log output

Server has no issues (API endpoint https://artemis.fim.uni-passau.de/api/exercises/279/results-with-points-per-criterion?withSubmissions=false returns data with code 200), only client error:

ERROR TypeError: i.pointsPerCriterion.forEach is not a function
    _e result.service.ts:264
    convertResultsWithPointsResponse result.service.ts:260
    _e result.service.ts:231
    RxJS 24
    Angular 17
    RxJS 82
    constructCSV exercise-scores-export-button.component.ts:58
    exportResults exercise-scores-export-button.component.ts:48
core.mjs:7204:18
@b-fein b-fein added the bug label Dec 11, 2024
@github-actions github-actions bot added assessment Pull requests that affect the corresponding module exercise Pull requests that affect the corresponding module programming Pull requests that affect the corresponding module labels Dec 11, 2024
@b-fein b-fein added the client Pull requests that update TypeScript code. (Added Automatically!) label Dec 11, 2024
@chrisknedl chrisknedl self-assigned this Jan 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
assessment Pull requests that affect the corresponding module bug client Pull requests that update TypeScript code. (Added Automatically!) exercise Pull requests that affect the corresponding module programming Pull requests that affect the corresponding module
Projects
None yet
2 participants