diff --git a/configure.ac b/configure.ac index 1d868e4a611..6642782ca6b 100644 --- a/configure.ac +++ b/configure.ac @@ -4635,5 +4635,12 @@ if test "X$HDF_FORTRAN" = "Xyes"; then esac fi +## HDF5 configure code created by autotools with gcc 4.9.2 is adding problematic +## linker flags: -l with no library name; -l , specifically gfortran or m. +## This sed script corrects "-l " first and then "-l " with no library name. +## If the order is not preserved, all instances of "-l " will be removed. +sed -e '/^postdeps/ s/-l \([a-zA-Z]\)/-l\1/g' -e '/^postdeps/ s/-l //g' libtool > libtool.bak +mv -- libtool.bak libtool + ## show the configure settings cat src/libhdf5.settings diff --git a/release_docs/RELEASE.txt b/release_docs/RELEASE.txt index 969ad835eee..16ef5171050 100644 --- a/release_docs/RELEASE.txt +++ b/release_docs/RELEASE.txt @@ -1014,6 +1014,40 @@ Bug Fixes since HDF5-1.14.3 release Configuration ------------- + - Fixed/reverted an Autotools configure hack that causes problems on MacOS + + A sed line in configure.ac was added in the past to paper over some + problems with older versions of the Autotools that would add incorrect + linker flags. This used the -i option in a way that caused silent + errors on MacOS that did not break the build. + + The original fix for this problem (in 1.14.4) removed the sed line + entirely, but it turns out that the sed cleanup is still necessary + on some systems, where empty -l options will be added to the libtool + script. + + This sed line has been restored and reworked to not use -i. + + Fixes GitHub issues #3843 and #4448 + + - Fixed a list index out of range issue in the runTest.cmake file + + Fixed an issue in config/cmake/runTest.cmake where the CMake logic + would try to access an invalid list index if the number of lines in + a test's output and reference files don't match + + - Fix Autotools -Werror cleanup + + The Autotools temporarily scrub -Werror(=whatever) from CFLAGS, etc. + so configure checks don't trip over warnings generated by configure + check programs. The sed line originally only scrubbed -Werror but not + -Werror=something, which would cause errors when the '=something' was + left behind in CFLAGS. + + The sed line has been updated to handle -Werror=something lines. + + Fixes one issue raised in #3872 + - Changed default of 'Error on HDF5 doxygen warnings' DOXYGEN_WARN_AS_ERROR option. The default setting of DOXYGEN_WARN_AS_ERROR to 'FAIL_ON_WARNINGS' has been changed @@ -1023,16 +1057,6 @@ Bug Fixes since HDF5-1.14.3 release * HDF5_ENABLE_DOXY_WARNINGS: ON/OFF (Default: OFF) * --enable-doxygen-errors: enable/disable (Default: disable) - - Removed an Autotools configure hack that causes problems on MacOS - - A sed line in configure.ac was added in the past to paper over some - problems with older versions of the Autotools that would add incorrect - linker flags. This hack is not needed with recent versions of the - Autotools and the sed line errors on MacOS (though this was a silent - error that didn't break the build) so the hack has been removed. - - Fixes GitHub issue #3843 - - Fixed an issue where the h5tools_test_utils test program was being installed on the system for Autotools builds of HDF5